Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inexistent docker image in generated Dockerfile #1349

Open
kidandcat opened this issue Oct 26, 2023 · 3 comments
Open

Inexistent docker image in generated Dockerfile #1349

kidandcat opened this issue Oct 26, 2023 · 3 comments

Comments

@kidandcat
Copy link

Description

When using amber new app, the generated Dockerfile is requiring FROM amberframework/amber:1.4.1. But that image do not exist in the docker registry: https://hub.docker.com/r/amberframework/amber/tags

Steps to Reproduce

  1. amber new app
  2. docker compose up

Expected behavior: App start

Actual behavior:
failed to solve: amberframework/amber:1.4.1: docker.io/amberframework/amber:1.4.1: not found

Reproduces how often: 100%

Versions

Amber CLI (amberframework.org) - v1.4.1

Crystal 1.10.1 (2023-10-13)
LLVM: 15.0.7
Default target: x86_64-apple-macosx

MacOS Sonoma (M2) 14.1

Additional Information

Changing it to FROM amberframework/amber:latest works.

@redrick
Copy link

redrick commented Nov 19, 2023

Hey sorry I hit this just browsing around. I was also solving this , I just went back to this repo and switch to whatever version/tag I am using (now is that 1.4.1 you mentioned):

git checkout v1.4.1

And the Dockerfile is in root, so I just tag it the same way as the default generated app has it:

docker build -t amberframework/amber:1.4.1 .

NOTE: I don't use the migrate service from compose, I do it by hand with docker exec -it YOUR-AMBER-APP bash

hope it helps somebody ;)

@drujensen
Copy link
Member

It would be good to create multi-platform images automatically and push them. Unfortunately, it requires hosting your own servers to build them which costs money.

@xendk
Copy link

xendk commented Jun 6, 2024

I might be missing something here, but I would think it's just setting up a Github Action to build and push the image?

https://github.com/reload/php-fpm/blob/main/.github/workflows/release.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants