From bffaa44db9290e783f4b94488408e303a7f4f704 Mon Sep 17 00:00:00 2001
From: Vixea <112600048+Vixea@users.noreply.github.com>
Date: Thu, 1 Jun 2023 12:34:56 -0500
Subject: [PATCH] Settings: Better Defaults (#1650)

* Settings: Increase saturation multiplier

Reason: Because of inaccuracies of the network latency estimation algorithm which cause it to be more conservative

* Settings: Be more generous with FR

Reason: at the default values shimmering at the edges these values make it much least noticeable and still very functional for users with low-end hardware(people with higher end hardware can always just increase it if they want no shimmer

* Settings: Update saturation and change schema settings

Reason: Last value causes frames to get bunched up and it doesn't make sense to have one setting have a step size of 0.05
---
 alvr/session/src/settings.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/alvr/session/src/settings.rs b/alvr/session/src/settings.rs
index 8218faf44c..00c1a068a0 100644
--- a/alvr/session/src/settings.rs
+++ b/alvr/session/src/settings.rs
@@ -247,7 +247,7 @@ pub enum BitrateMode {
             help = "Percentage of network bandwidth to allocate for video transmission"
         ))]
         #[schema(flag = "real-time")]
-        #[schema(gui(slider(min = 0.5, max = 2.0, step = 0.05)))]
+        #[schema(gui(slider(min = 0.5, max = 5.0, step = 0.01)))]
         saturation_multiplier: f32,
 
         #[schema(strings(display_name = "Maximum bitrate"))]
@@ -916,7 +916,7 @@ pub fn session_settings_default() -> SettingsDefault {
                 mode: BitrateModeDefault {
                     ConstantMbps: 30,
                     Adaptive: BitrateModeAdaptiveDefault {
-                        saturation_multiplier: 0.95,
+                        saturation_multiplier: 1.0,
                         max_bitrate_mbps: SwitchDefault {
                             enabled: false,
                             content: 100,
@@ -1030,8 +1030,8 @@ pub fn session_settings_default() -> SettingsDefault {
             foveated_rendering: SwitchDefault {
                 enabled: true,
                 content: FoveatedRenderingDescDefault {
-                    center_size_x: 0.4,
-                    center_size_y: 0.35,
+                    center_size_x: 0.45,
+                    center_size_y: 0.4,
                     center_shift_x: 0.4,
                     center_shift_y: 0.1,
                     edge_ratio_x: 4.,