Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor P&L graph calculations to not use libraries #109

Open
IanWoodard opened this issue Oct 6, 2022 · 0 comments
Open

Refactor P&L graph calculations to not use libraries #109

IanWoodard opened this issue Oct 6, 2022 · 0 comments
Assignees
@haydenshively @IanWoodard

Comments

@IanWoodard
Copy link
Collaborator

Since the graph is just for reference, precision is not of utmost importance. Because of this, it may make sense to refactor the P&L graph calculations to use regular js math rather than JSBI, BigNumber, or Big.js. This refactor should lead to less of a performance strain as the computations would be less intensive.
@IanWoodard IanWoodard changed the title Refactor P&L graph calculations to not use math libraries Refactor P&L graph calculations to not use libraries Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haydenshively haydenshively

@IanWoodard IanWoodard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haydenshively @IanWoodard