Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional SoftwareKeyboard Improvements #256

Open
MarkOates opened this issue Jun 12, 2023 · 0 comments
Open

Additional SoftwareKeyboard Improvements #256

MarkOates opened this issue Jun 12, 2023 · 0 comments

Comments

@MarkOates
Copy link
Collaborator

MarkOates commented Jun 12, 2023

Below is a set of items to consider for improving the SoftwareKeyboard/SoftwareKeyboard.

✅ show rounded rectangle around text box for error input
  ✅ show error messages below rounded textbox
- when all characters have been entered, grey out all possible characters that can be used (except backspace for example)
- when at the first character, gray out backspace character
- give option to hide cursor
  - smoothly
  - instantly
- give option to show cursor
  - smoothly
  - instantly
- add sound effect events
  - moving cursor
    - bonus: wrap-moving cursor
  - pressing key
  - pressing backspace
  - pressing "OK"
❌ make "OK" key text customizable (probably won't do this because this is dependent on the keys on the keyboard and the press_key_by_name function). To do this, you might modify the "keys". Find the key you want to modify, in this case the "SUBMIT" key, and change it's label.
  ❌ prevent from being "SPACE", "SPACEBAR", "BACKSPACE" (in any casing) (won't do this because this is dependnet on the keys on the keyboard and the press_key_by_name function)
- Consider writing some documentation
- Resolve TODOs
- internally, rename "OK" key to "SUBMIT"
✅ add callback on "OK" keypress
- consider adding top-left "ESC" key hint
- tweak the cursor (in the text input) so it does not display the character that the cursor is currently over
- change "cannot be empty" to cannot be blank
- disable interactive test
- would like to remove event emitter dependency and "event_to_emit_on_pressing_submit_key" in favor of factory function


- bonus:
  - add option to remove border and background around keyboard
  - add submit callback on Screens/CharacterNameInput
  - setting the text, when larger than the number of permitted characters, should crash
  - consider adding SHIFT+enter as keypress

----

✅ clear error frame on:
  ✅ anything that is not a submit
    ❌ setting the result_text manually (no, this would cause side effects. If you wanted to clear, then the two steps will need to be done by the user)
    ✅ pressing any key (apparently other than OK) (special branching logic was added in the "press_key_by_name" function
    ❌ on show/hide (probably only in Screen)? (on the screen, this should be done by calling reset() on the SoftwareKeyboard)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant