Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in generator #3

Open
Waguy02 opened this issue Sep 18, 2022 · 0 comments
Open

Small bug in generator #3

Waguy02 opened this issue Sep 18, 2022 · 0 comments

Comments

@Waguy02
Copy link

Waguy02 commented Sep 18, 2022

image

Thanks for your code, it is very nice. But I found a little bug in the bar_generator code.
In fact, the last Reshape() layer in the network definition has an incorrect size. As you mentionned, the output shape of the last conv is (batch_size, out_channels, 8*hid_features//hid_channels, n_pitches) and the shape of Reshape layer is output shape: (batch_size, out_channels, 1, n_steps_per_bar, n_pitches). Such configuration works very well only when n_steps_per_bar is set to 16 but One would run experiment with a different n_steps_per_bar. (I run it with 48 steps per bar as far as I am concerned in fact).

For a more general purpose, I propose to add a linear mapping before that Reshape layer as shown in the figure attached.

Yours sincerely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant