-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 17 #20
Comments
I'm not sure how accurate "around the corner" is. As for #14, see #14 (comment). |
Do we expect to have React 17 support? |
I do expect to have it. |
Landing here due to incorrect peer dependenciy warnings from |
@mhatvan they're currently correct warnings. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yep, you're right. But this may be to so complex as expected. React 18 is rather close to getting launched, and folks are still not able to migrate to React 17. It's not correct to go with this warning, as it means dependency is not correct and something may get broken. |
Correct. Your choices remain to stay on react 16, or stop using this library. |
React 17 is around the corner and this package still relies on the unsafe
componentWillRecieveProps
. I attempted to make a pr to mark it as unsafe but this breaks with pre 16 react versions. Can we move forward and remove support for pre 16 react? If not switching tocomponentDidUpdate
in this PR #14 seems like the logical way forward.The text was updated successfully, but these errors were encountered: