Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 #20

Open
birge opened this issue Aug 20, 2019 · 12 comments
Open

React 17 #20

birge opened this issue Aug 20, 2019 · 12 comments

Comments

@birge
Copy link

birge commented Aug 20, 2019

React 17 is around the corner and this package still relies on the unsafe componentWillRecieveProps. I attempted to make a pr to mark it as unsafe but this breaks with pre 16 react versions. Can we move forward and remove support for pre 16 react? If not switching to componentDidUpdate in this PR #14 seems like the logical way forward.

@ljharb
Copy link
Collaborator

ljharb commented Aug 20, 2019

I'm not sure how accurate "around the corner" is.

As for #14, see #14 (comment).

@balovbohdan
Copy link

Do we expect to have React 17 support?

@ljharb
Copy link
Collaborator

ljharb commented May 24, 2021

I do expect to have it.

@mcmxcdev
Copy link

mcmxcdev commented Jul 9, 2021

Landing here due to incorrect peer dependenciy warnings from yarn install for react and react-dom, would be great to get this resolved!

@ljharb
Copy link
Collaborator

ljharb commented Jul 13, 2021

@mhatvan they're currently correct warnings.

@nbstr

This comment has been minimized.

@JustFly1984

This comment has been minimized.

@balovbohdan

This comment has been minimized.

@ljharb

This comment has been minimized.

@balovbohdan
Copy link

#32

@balovbohdan
Copy link

@balovbohdan thats hostile, untrue, and unnecessary. Everybody cares a lot, which is why we won’t update the peer dep until we’re able to test it. It would be reckless to do so otherwise.

Yep, you're right. But this may be to so complex as expected. React 18 is rather close to getting launched, and folks are still not able to migrate to React 17. It's not correct to go with this warning, as it means dependency is not correct and something may get broken.

@ljharb
Copy link
Collaborator

ljharb commented Jan 4, 2022

Correct. Your choices remain to stay on react 16, or stop using this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants