Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring fennel? #169

Open
jaidetree opened this issue Aug 23, 2022 · 2 comments
Open

Vendoring fennel? #169

jaidetree opened this issue Aug 23, 2022 · 2 comments

Comments

@jaidetree
Copy link
Collaborator

Just a thought but would it be unreasonable to include fennel source and the other packages we use in the project?

Pros

  • Static install location
  • Remove luarocks
  • More stable, so when fennel updates spacehammer is not broken

Cons

  • Bigger repo size
  • Fennel wouldn't be available system-wide, but not sure how common that is for people to use outside of spacehammer?
  • A script to update those packages would probably be required, but potentially more straight forward than trying to write a package system

If anyone has experience or strong opinions on this, please weigh in!

@Grazfather
Copy link
Collaborator

I have thought about this as well. I think it's a good idea. Fennel is intentionally a single file and they encourage its full source inclusion
the_Fennel_programming_language
.

@Grazfather
Copy link
Collaborator

Bump on this. #176 I'd like to update some of our code, but I don't want to force us to update.

Only concern I can think of is if we have users whose configs use module they have installed that might break on an update. That said, fennel is pretty good at maintaining backwards compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants