Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Tidy up loaders and writers #2325

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ENH] Tidy up loaders and writers #2325

wants to merge 4 commits into from

Conversation

TonyBagnall
Copy link
Contributor

Fixes #1931

Tidy up the loaders and writers. Thery dont work with df-list or multindex as yet, but if any demand for this can do it.

@TonyBagnall TonyBagnall added the datasets Datasets and data loaders label Nov 8, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Nov 8, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#0B1D38}{\textsf{datasets}}$, $\color{#45FD64}{\textsf{examples}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't edit the changelogs, assume this was a refactoring mistake

Comment on lines +38 to +40
suffix: str or None, default=None
Addon at the end of the filename before the file extension, i.e. _TRAIN or
_TEST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is suffix necessary? can just be a part of problem_name right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its necessary for unequal etc

@MatthewMiddlehurst
Copy link
Member

still an edited changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Datasets and data loaders enhancement New feature, improvement request or other non-bug code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Improvements to write_to_tsfile
2 participants