Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Excluded estimators and tests #2230

Open
8 of 30 tasks
TonyBagnall opened this issue Oct 18, 2024 · 0 comments
Open
8 of 30 tasks

[ENH] Excluded estimators and tests #2230

TonyBagnall opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request

Comments

@TonyBagnall
Copy link
Contributor

TonyBagnall commented Oct 18, 2024

Describe the feature or idea you want to propose

the new testing set up has identified a lot of new previously undisclosed test fails, resulting in many exclusions. These are listed in testing_config, and listed below. It would be good to have issues with each exclusion, to help find solutions, see #2071 for a starting point

Describe your proposed solution

Excluded estimators

  • SeriesSearch
  • QuerySearch
  • ClearSkyTransformer
  • RandomDilatedShapeletTransform
  • RDSTRegressor
  • RISTRegressor

excluded tests (excluded for unknown reasons)

  • "LearningShapeletClassifier": ["check_fit_deterministic"], # has a keras fail, unknown reason, see [BUG] Fix LearningShapeletClassifier non-standard methods #1387
  • "TapNetClassifier": ["check_classifier_random_state_deep_learning"], # does not fit structure for test, needs investigation
  • "TapNetRegressor": ["check_regressor_random_state_deep_learning"],
  • "SASTClassifier": ["check_fit_deterministic"],
  • "RSASTClassifier": ["check_fit_deterministic"],
  • "SAST": ["check_fit_deterministic"],
  • "RSAST": ["check_fit_deterministic"],
  • "AEFCNClusterer": ["check_fit_updates_state"], Fixed in [BUG[ Use clone estimator in BaseDeepClusterer to fix check_fit_updates_state fail #2309
  • "AEResNetClusterer": ["check_fit_updates_state"], Fixed in [BUG[ Use clone estimator in BaseDeepClusterer to fix check_fit_updates_state fail #2309
  • "SFA": ["check_persistence_via_pickle", "check_fit_deterministic"],
  • "CollectionId": ["check_transform_inverse_transform_equivalent"],
  • "ScaledLogitSeriesTransformer": ["check_transform_inverse_transform_equivalent"],
  • "MockMultivariateSeriesTransformer": [
    "check_transform_inverse_transform_equivalent"
    ],

    missed in legacy testing, changes state in predict/transform

  • "FLUSSSegmenter": ["check_non_state_changing_method"],
  • "InformationGainSegmenter": ["check_non_state_changing_method"],
  • "GreedyGaussianSegmenter": ["check_non_state_changing_method"],
  • "ClaSPSegmenter": ["check_non_state_changing_method"],
  • "HMMSegmenter": ["check_non_state_changing_method"],
  • "BinSegSegmenter": ["check_non_state_changing_method"],
  • "QUANTTransformer": ["check_non_state_changing_method"],
  • "MatrixProfileSeriesTransformer": ["check_non_state_changing_method"],
  • "PLASeriesTransformer": ["check_non_state_changing_method"],
  • "AutoCorrelationSeriesTransformer": ["check_non_state_changing_method"],
  • "SIVSeriesTransformer": ["check_non_state_changing_method"],

Describe alternatives you've considered, if relevant

No response

Additional context

No response

@TonyBagnall TonyBagnall added enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request labels Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement testing Testing related issue or pull request
Projects
None yet
Development

No branches or pull requests

1 participant