Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP] Deprecate Differencer transformer #1535

Merged
merged 2 commits into from
May 21, 2024
Merged

[DEP] Deprecate Differencer transformer #1535

merged 2 commits into from
May 21, 2024

Conversation

TonyBagnall
Copy link
Contributor

Fixes #700 resolves #1534

Deprecate broken Differencer class

@TonyBagnall TonyBagnall added transformations Transformations package deprecation This issue is related to deprecation or removal of code labels May 17, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree the implementation is overly complex for what it is, but I can see the use in a differencer transform. Should be a nice good first issue to do it in the new interface?

@TonyBagnall
Copy link
Contributor Author

Agree the implementation is overly complex for what it is, but I can see the use in a differencer transform. Should be a nice good first issue to do it in the new interface?

yes for sure, good idea, particularly a working inverse

@TonyBagnall TonyBagnall merged commit 16a19bb into main May 21, 2024
14 checks passed
@TonyBagnall TonyBagnall deleted the ajb/differencer branch May 21, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation This issue is related to deprecation or removal of code transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Deprecate Differencer [BUG] Differencer transformer fails test_transform_inverse_transform_equivalent
2 participants