Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name normalization should include .strip(), or at least .lstrip() #71

Open
seasidesparrow opened this issue Oct 25, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@seasidesparrow
Copy link
Member

Describe the bug
There is at least one instance of publisher-supplied metadata supplying a surname with extraneous left spaces. This has a downstream effect that interferes with the current ADSIngestEnrichment bibcode generator; that code selects the left-most character for the author initial (name[0]). The issue will be fixed in the enrichment package, but this is a data normalization issue that should happen at parse time.

To Reproduce
From the 2023-10-21 data delivery from IOP, take the file 2053-1591_10_10_105303/mrx_10_10_105303.xml which has the first author's name fielded as <surname> M</surname> (note preceeding space). Parse the file with JATSParser().parse. The resulting json will include

  "authors": [
    {
      "name": {
        "surname": " M",

Additional context
Add any other context about the problem here.

@seasidesparrow seasidesparrow added the bug Something isn't working label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant