Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base parser should include code for entity normalization #106

Open
seasidesparrow opened this issue May 7, 2024 · 0 comments
Open

Base parser should include code for entity normalization #106

seasidesparrow opened this issue May 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@seasidesparrow
Copy link
Member

Is your feature request related to a problem? Please describe.
The ADS has a policy for converting some HTML entities to their ascii equivalent. For example, „ should be converted to ascii double quotes (") as part of record normalization. This can and should happen at parse time, because it's something that's done for all incoming records.

The old ingest parser had code to do this work here: https://github.com/adsabs/adsabs-pyingest/blob/master/pyingest/parsers/entity_convert.py

Describe the solution you'd like
A generic entity converter should be implemented in base parser, so that all fields are subject to normalization at parse time.

Additional context
Add any other context or screenshots about the feature request here.

@seasidesparrow seasidesparrow added the enhancement New feature or request label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant