Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [RAC] BreadCrumbs now pass through with useRenderProps #7214

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: [RAC] BreadCrumbs now pass through with useRenderProps #7214

wants to merge 2 commits into from

Conversation

syd03098
Copy link
Contributor

@syd03098 syd03098 commented Oct 21, 2024 •
edited
Loading

Closes

  • Nothing, but similar with this: fix: ensure Dialog has the data-rac attribute #7189
  • Now BreadCrumbs has the data-rac attribute
  • I thought it would be great if the StyleRenderProps inside BreadCrumbs has attributes for focusWithin, focusVisible, isDisabled for my personal project.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@syd03098 syd03098 changed the title fix: BreadCrumbs now pass through with useRenderProps fix: [RAC] BreadCrumbs now pass through with useRenderProps Oct 21, 2024
@syd03098 syd03098 marked this pull request as ready for review October 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@syd03098