Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement of the filter for not a having a feature. #1031

Open
dglaude opened this issue Aug 23, 2022 · 3 comments
Open

Enhancement of the filter for not a having a feature. #1031

dglaude opened this issue Aug 23, 2022 · 3 comments

Comments

@dglaude
Copy link
Contributor

dglaude commented Aug 23, 2022

Right now you can filter for board with feature X, but you cannot filter for board that do not have feature X.
I used the "display" filter to identify board that might pretend to have a display, but not really.
I would like to use the "no display" filter to identify (visually) board with a display but that forgot to advertise it.

There could be other use for such negative filtering, and I have no clue how to make a user interface that make that easy.
Right now my use case is of limited interest and might make things too complex for few benefits.

@makermelissa
Copy link
Collaborator

Hmm, this could be interesting. We'd have to think about how the UI would function.

@FoamyGuy
Copy link
Contributor

This feels to me like a fairly niche / maintenance focused feature.

My initial inclination would be to implement it without a visual UI. The current filter checkboxes add the values checked to to the URL as parameters e.g. ?features=Display which then makes it behave like a search term limiting the list to only device which have the specified features.

I would propose to modify the JS that handles the limiting based on features functionality to support a negative modifier in the value so a value of -Display would denote "not Display".

In order to use this feature the user would have to know of it's existence and modify the URL by adding the minus signs to whichever features they're interested in.

@FoamyGuy
Copy link
Contributor

I poked at this for a little bit but did not end up finding the right way or place to change the filtering behavior to invert it for the "not" effect. I do think it's possible, but might be more complex than my original comment makes it sound even if we do skip the visual UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants