Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branches and paths are not inclusive #3570

Open
georeith opened this issue Nov 14, 2024 · 0 comments
Open

branches and paths are not inclusive #3570

georeith opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@georeith
Copy link

georeith commented Nov 14, 2024

Describe the bug

The documentation states:

If you define both branches/branches-ignore and paths/paths-ignore, the workflow will only run when both filters are satisfied.

However this is not the case in our repository, if you specify branches: ** and include paths then the action runs on any commit to any branch.

To Reproduce
I tried to make a simple reproduction but I couldn't reproduce the issue there: georeith/action-filter-bug-repro#1. Which leads me to believe it's something to do with the overall size of our repo, it's a very large repository. Unfortunately it's a private repository but I will show screenshots that show it's misbehaving:

image
image

The contents of the action are:

name: Sync Translations Push

on:
  push:
    branches:
      - '**'
    paths:
      - 'locale/en.json'
      - '.github/workflows/syncTranslations.yml'
      - '.github/workflows/syncTranslationsPush.yml'
      - 'crowdin.yml'

jobs:
  syncTranslations:
    uses: ./.github/workflows/syncTranslations.yml
    name: Sync Translations
    secrets:
      CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }}
      CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }}

Expected behavior

The action should only run when both filters are satisfied.

Runner Version and Platform

Version of your runner?

Ubuntu

What's not working?

See above

@georeith georeith added the bug Something isn't working label Nov 14, 2024
@georeith georeith changed the title branches and paths are not mutually inclusive branches and paths are not inclusive Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant