You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 3, 2022. It is now read-only.
The allowRetries option currently only applies OPTIONS, GET, DELETE and HEAD (see RetryableHttpVerbs since those operations are idempotent by default. This is a good default and avoids any unintended side effects.
There should be an option for the client to specify allowing retries for specific write operations (PUT and POST) if the client knows they are idempotent.
The text was updated successfully, but these errors were encountered:
@joshmgross - since this is so specific to the caller, scenario, and potentially a dangerous thing to do, I think it's best for the consumer to do the retries. Either that or the option is allow unsafeWriteRetries? (sort of how a compiler makes unsafe optional stuff clear). Thoughts?
I think an unsafeWriteRetries option would work, as it clarifies that it's potentially dangerous.
Making the consumer implement their own retries is fine, but ends up just duplicating code that's already contained in this package and could potentially introduce issues if not implemented correctly.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The
allowRetries
option currently only appliesOPTIONS
,GET
,DELETE
andHEAD
(seeRetryableHttpVerbs
since those operations are idempotent by default. This is a good default and avoids any unintended side effects.There should be an option for the client to specify allowing retries for specific write operations (
PUT
andPOST
) if the client knows they are idempotent.The text was updated successfully, but these errors were encountered: