Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart - Enable Custom Annotations and Labels for AutoscalingRunnerSet #3722

Open
omerap12 opened this issue Aug 25, 2024 · 4 comments
Open
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers

Comments

@omerap12
Copy link

What would you like added?

Currently, there is no option to add custom annotations or labels to the AutoscalingRunnerSet. I would like to request the addition of this feature.

Why is this needed?

This feature would allow us to apply our own annotations or labels, such as the "karpenter do-not-evict" annotation, enabling more granular control and customization.

Additional context

Add any other context or screenshots about the feature request here.

@omerap12 omerap12 added community Community contribution enhancement New feature or request needs triage Requires review from the maintainers labels Aug 25, 2024
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@omerap12 omerap12 changed the title Chart - Configure annotations and labels in AutoscalingRunnerSet. Chart - Enable Custom Annotations and Labels for AutoscalingRunnerSet Aug 25, 2024
@omerap12
Copy link
Author

Just to clarify, I would like the option to add labels to the AutoscalingRunnerSet, which will propagate to the pods it creates.

@4c74356b41
Copy link

how is this not a thing? nobody is using these at all? thats one of the top things any1 would require

@4c74356b41
Copy link

@omerap12 hey, this might help you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

2 participants