Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to scale up runners with scaleUpFactor option #3694

Open
4 tasks done
akhilp6 opened this issue Aug 1, 2024 · 1 comment · May be fixed by #3688
Open
4 tasks done

Ability to scale up runners with scaleUpFactor option #3694

akhilp6 opened this issue Aug 1, 2024 · 1 comment · May be fixed by #3688
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@akhilp6
Copy link

akhilp6 commented Aug 1, 2024

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

Check the in the gha-runner-scale-set chart, there's no way to set `sclaeUpFactor in `values.yaml` for the actions.github.com_autoscalingrunnersets.yaml

Describe the bug

Currently the runners scales up based on the count of jobs requested. For example, let say if we get a 5 new job request then it basically add 5 new runners. This approach is increasing our start up time as it basically queue up until all the runners are started. We would like to have some kind of scaleUpFactor option which would basically pre-load the runners which would help in decreasing the start up time.

Describe the expected behavior

N/A

Additional Context

N/A

Controller Logs

N/A

Runner Pod Logs

N/A
@akhilp6 akhilp6 added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Aug 1, 2024
@xunholy
Copy link
Contributor

xunholy commented Nov 13, 2024

@akhilp6 how does this differ from minRunners? Is the idea you'd always create slightly more than the queue depth on Github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
2 participants