Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license-expression library #91

Open
steven-esser opened this issue Mar 28, 2018 · 6 comments
Open

Add license-expression library #91

steven-esser opened this issue Mar 28, 2018 · 6 comments

Comments

@steven-esser
Copy link
Contributor

To support #90, we should add the https://github.com/nexB/license-expression library to DeltaCode and update our algorithm to use this library.

@Pratikrocks
Copy link
Collaborator

@MaJuRG , @johnmhoran could you explain a bit more about the context of this issue , In what terms will we use this library ?

@johnmhoran
Copy link
Member

Hi @Pratikrocks . The scan files produced by https://github.com/nexB/scancode-toolkit contain a number of fields, including license_expression. Our goal is to find a way for DeltaCode -- which compares two ScanCode-Toolkit result files -- to compare and score pairs of simplified license expression values, and we'll need the https://github.com/nexB/license-expression library to do more detailed comparisons.

@Pratikrocks
Copy link
Collaborator

Thanks @johnmhoran for the explanation

@Pratikrocks
Copy link
Collaborator

Pratikrocks commented Mar 20, 2020

I was thinking to integrate license-expresiion library to deltacode in the following manner::

We would provide an option for the user in the command line to specify a license type (eg:MIT..,may be more than one),then based upon the choice we would show the deltas/print in json(or csv) file where either my old or new file has the license(s) specified by the user.

Moreover we could also provide another command line arguments to display if the deltas when explicitly new path has a license.

Actually in this way we can Implement many different queries based upon the license detection

I was planning to integrate this way .What are your views @MaJuRG , @johnmhoran regarding this

@steven-esser
Copy link
Contributor Author

No, we just want the library for handling license_expression strings.

@Pratikrocks
Copy link
Collaborator

okay @MaJuRG ,this will be effective in detecting the licenses more proficiently, moreover some redundant methods could be reduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants