Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty path strings in outputs appear after some alignments #35

Open
steven-esser opened this issue Dec 8, 2017 · 3 comments
Open

empty path strings in outputs appear after some alignments #35

steven-esser opened this issue Dec 8, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@steven-esser
Copy link
Contributor

When running

deltacode -n tests/data/deltacode/ecos-failed-counts-assertion-new.json -o tests/data/deltacode/ecos-failed-counts-assertion-old.json -c ~/test.csv

Many modified or license change Deltas show an empty path value in our output. I believe this happens as a result of align_scan(), but I could be wrong. I will investigate further and post more details.

@steven-esser
Copy link
Contributor Author

This might also be because we have modified the constructors of file object, but I cannot be sure.

@johnmhoran
Copy link
Member

@MaJuRG Running your ecos command, I see empty path entries that begin at the point the modified/license change category begins -- the empty fields seem to run from row 5,482 to row 734,383 (still inside the modified/license change category). (I might have missed some in the intervening rows.) Didn't see this in any of the other 3 categories.

Just ran a delta on zlib-1.2.9 vs zlib-1.2.11 -- saw no similar empty entries.

@steven-esser
Copy link
Contributor Author

steven-esser commented Dec 8, 2017

At first I thought the same, but there are a few in unmodified as well, so its not just the modified bucket.

This may be a weird issue with these particular ecos scans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants