Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cipher errors #33

Open
mattheworiordan opened this issue Aug 31, 2018 · 1 comment
Open

Cipher errors #33

mattheworiordan opened this issue Aug 31, 2018 · 1 comment
Assignees
Labels

Comments

@mattheworiordan
Copy link
Member

mattheworiordan commented Aug 31, 2018

In the Ruby lib, I use six error codes that don't exist in ably-common:

  • 92005 - invalid Cipher arguments
  • 92004 - unsupported cipher algorithm
  • 92001 - Message cannot be decrypted as the channel is not set up for encryption & decryption
  • 92002 - Cipher algorithm [X] does not match message cipher algorithm [Y]
  • 92003 - CipherError decrypting data, the private key may not be correct
  • 92100 - Encoding error, encoding value is too long (when encoding is greater than 512 chars)

Should we define these or similar error codes in ably-common?

@SimonWoolf
Copy link
Member

👍 sure, why not. in which case we should probably also add them to the spec too.

(fwiw ably-js currently does most of those as plain Errors without an error code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants