Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

King County COVID19 - Bug: Language attributes are missing for the languages in the middle of the page #6

Open
lamarjordanux opened this issue Apr 29, 2020 · 2 comments
Labels
bug Something isn't working King County COVID-19 Issues logged for the King County COVID-19 site

Comments

@lamarjordanux
Copy link

Issue Summary

Screen readers may not announce the language properly without lang attributes.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to one of the language buttons in the middle of the page
  2. Inspect the button code

Behavior

Expected behavior

Screen reader pronounces the language in native tongue.

Actual behavior

  • Screen reader pronounces language in English

Versions

Device Information:

  • OS: NVDA
  • Browser Chrome
  • Version [e.g. 22]

Screen Reader or AT Information

  • [e.g. JAWS 2020.2003.13]
  • [e.g. NVDA 2019.3.1]

Screenshots

If applicable, add screenshots to help explain your problem.

Code

Current Code

(code snippet)

Suggested Code

(code snippet)

Specifications

  • WCAG Principal:
  • WCAG SC:
  • Severity:

Additional References

  • Link to any articles or specs that give further guidance
@smhigley smhigley added bug Something isn't working King County COVID-19 Issues logged for the King County COVID-19 site labels Apr 29, 2020
@dpersing
Copy link
Member

Screenshot of the language controls

@alboss
Copy link

alboss commented Apr 30, 2020

Current code:
<a class="btn btn-primary btn-block" href="/depts/health/covid-19/languages/spanish.aspx" role="button" data-toggle="tooltip" data-placement="left" title="" data-original-title="COVID-19 Recomendaciones de Salud Pública">Spanish <span class="fas fa-long-arrow-alt-right" aria-hidden="true"></span> Español</a>

Suggested code:
<a class="btn btn-primary btn-block" href="/depts/health/covid-19/languages/spanish.aspx" role="button" data-toggle="tooltip" data-placement="left" title="" data-original-title="COVID-19 Recomendaciones de Salud Pública">Spanish <span class="fas fa-long-arrow-alt-right" aria-hidden="true"></span> <span lang="es">Español</span></a>

What changed?
Español is now <span lang="es">Español</span> so a text reader will read it as a Spanish word instead of sounding it out as an English word and mispronouncing it.

Impact: Essential for text readers.

Difficulty of change: tedious but not difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working King County COVID-19 Issues logged for the King County COVID-19 site
Projects
None yet
Development

No branches or pull requests

4 participants