Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep all hetatms for all-atom graphs #415

Open
EvanKomp opened this issue Nov 4, 2024 · 3 comments
Open

Keep all hetatms for all-atom graphs #415

EvanKomp opened this issue Nov 4, 2024 · 3 comments

Comments

@EvanKomp
Copy link

EvanKomp commented Nov 4, 2024

Is your feature request related to a problem? Please describe.
Sort of. My use case includes loading all atom resolution including non protein atoms, and sending them eventually into PtG. I effectively cannot use Graphein as it stands in that I do not know the names of all hetatms in my dataset ahead of time.

Describe the solution you'd like
In addition to list of string, accept bool True. Add logic to check that granularity is compatible if necessary.

Describe alternatives you've considered
Parsing my whole dataset and sending in an absolutely massive list of hetatms

Thanks for your work.

@a-r-j
Copy link
Owner

a-r-j commented Nov 5, 2024

Hi @EvanKomp have you seen this API? https://colab.research.google.com/github/a-r-j/graphein/blob/master/notebooks/protein_tensors.ipynb#scrollTo=mpbEZJ4WmyQZ

It's a bit more suited for your use case. In particular, see protein_to_pyg and the keep_hets arg.

@EvanKomp
Copy link
Author

EvanKomp commented Nov 6, 2024

@a-r-j It looks like that function also requires keep_hets as a list. Is there no way to keep all hetatms without having to specify the names?

@a-r-j
Copy link
Owner

a-r-j commented Nov 6, 2024

Apologies, my bad. I think the store_het arg will keep everything, while keep_hets is for specifying a subset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants