Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AFW and BCG emphasis aware after refactoring #123

Open
pokutta opened this issue Mar 5, 2021 · 2 comments
Open

Make AFW and BCG emphasis aware after refactoring #123

pokutta opened this issue Mar 5, 2021 · 2 comments
Labels
Code improvements Code improvements enhancement New feature or request Low priority Low priority

Comments

@pokutta
Copy link
Member

pokutta commented Mar 5, 2021

After refactoring AFW and BCG we lost the memory awareness due to the subroutines. We should restore this. It is not that critical because both are hard on the memory anyways but it will still impact the speed of the iterations in particular, if we do not need to call the lmo.

@pokutta pokutta added enhancement New feature or request Code improvements Code improvements labels Mar 5, 2021
@matbesancon
Copy link
Member

matbesancon commented Mar 9, 2021

Once #121 is merged I'll look into it, but the iterate in BCG is already in-memory (it exists only within the active set).

@pokutta
Copy link
Member Author

pokutta commented Mar 9, 2021

Once #121 is merged I'll look into it, but the iterate in BCG is already in-memory (it exists only within the active set).

don't think this has to be a priority right now as we have to deal with memory of much higher order anyways. maybe mark as low priority.

@matbesancon matbesancon added the Low priority Low priority label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvements Code improvements enhancement New feature or request Low priority Low priority
Projects
None yet
Development

No branches or pull requests

2 participants