-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branching with non-trivial domain oracle #207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arting point is domain infeasible.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 86.23% 84.91% -1.32%
==========================================
Files 17 19 +2
Lines 1482 1598 +116
==========================================
+ Hits 1278 1357 +79
- Misses 204 241 +37 ☔ View full report in Codecov by Sentry. |
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Oct 29, 2024
matbesancon
reviewed
Nov 7, 2024
matbesancon
reviewed
Nov 7, 2024
matbesancon
reviewed
Nov 7, 2024
Co-authored-by: Mathieu Besançon <[email protected]>
Co-authored-by: Mathieu Besançon <[email protected]>
Co-authored-by: Mathieu Besançon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the domain oracle is non trivial, i.e. not all points in the feasible region are domain feasible for the objective, it can happen that after branching "normally" the iterate is domain infeasible.
Now, when we split the active set, we check the vertices for domain infeasibility. If a vertex is domain infeasible, it is dropped completely.