Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branching with non-trivial domain oracle #207

Merged
merged 39 commits into from
Nov 8, 2024
Merged

Branching with non-trivial domain oracle #207

merged 39 commits into from
Nov 8, 2024

Conversation

dhendryc
Copy link
Collaborator

In case the domain oracle is non trivial, i.e. not all points in the feasible region are domain feasible for the objective, it can happen that after branching "normally" the iterate is domain infeasible.

Now, when we split the active set, we check the vertices for domain infeasibility. If a vertex is domain infeasible, it is dropped completely.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 85.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (ee5cc6c) to head (9b89cad).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
src/utilities.jl 78.78% 7 Missing ⚠️
src/interface.jl 50.00% 1 Missing ⚠️
src/problem.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   86.23%   84.91%   -1.32%     
==========================================
  Files          17       19       +2     
  Lines        1482     1598     +116     
==========================================
+ Hits         1278     1357      +79     
- Misses        204      241      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/oed_utils.jl Outdated Show resolved Hide resolved
examples/oed_utils.jl Outdated Show resolved Hide resolved
src/node.jl Outdated Show resolved Hide resolved
src/utilities.jl Outdated Show resolved Hide resolved
examples/oed_utils.jl Outdated Show resolved Hide resolved
examples/oed_utils.jl Outdated Show resolved Hide resolved
src/utilities.jl Outdated Show resolved Hide resolved
dhendryc and others added 3 commits November 7, 2024 18:11
Co-authored-by: Mathieu Besançon <[email protected]>
Co-authored-by: Mathieu Besançon <[email protected]>
@dhendryc dhendryc merged commit 632ca6c into main Nov 8, 2024
2 of 3 checks passed
@dhendryc dhendryc deleted the domain-oracle-fix branch November 8, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants