Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DocString Warning #169

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix DocString Warning #169

merged 1 commit into from
Nov 15, 2023

Conversation

dhendryc
Copy link
Collaborator

The issue was that the abstract function is_linear_feasible existed twice with different explanations.

One was for the BoundedLinearMinimizationOracle, the other for SimpleBoundedLMO. By that the two do sightly different things, as the is_linear_feasibleof the SimpleBoundedLMO is a subroutine of is_linear_feasible function for the ManagedBoundedLMO.

Renamed it to is_simple_linear_feasible.

@dhendryc dhendryc linked an issue Nov 15, 2023 that may be closed by this pull request
@dhendryc dhendryc marked this pull request as ready for review November 15, 2023 14:38
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ee5cc6c) 86.23% compared to head (3b51b7d) 86.36%.
Report is 7 commits behind head on main.

Files Patch % Lines
src/interface.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   86.23%   86.36%   +0.13%     
==========================================
  Files          17       17              
  Lines        1482     1482              
==========================================
+ Hits         1278     1280       +2     
+ Misses        204      202       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dhendryc dhendryc merged commit 3252179 into main Nov 15, 2023
5 checks passed
@dhendryc dhendryc deleted the doc-string-warning branch November 15, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc String Warning
1 participant