Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that the abstract function
is_linear_feasible
existed twice with different explanations.One was for the
BoundedLinearMinimizationOracle
, the other forSimpleBoundedLMO
. By that the two do sightly different things, as theis_linear_feasible
of theSimpleBoundedLMO
is a subroutine ofis_linear_feasible
function for theManagedBoundedLMO
.Renamed it to
is_simple_linear_feasible
.