-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Playground-based applications to dedicated repositories #473
Comments
|
@danielbachhuber I remember you preferred to focus on the CLI tool and I'm happy to the VS Code extension in the https://github.com/WordPress/playground-tools repo for now.
No changes there:
|
A third question:
For clarity, who is this? It'd probably be good to have a |
Is this relevant for the move? I'd like to keep this issue focused but we can discuss that separately in another one.
Communication around Playground governance will follow soon, this issue is about code organization. Is there anything specific you're concerned about? Setting up a team sounds like a great idea 👍 |
Yes — it's a question of whether they share the same fundamentals or not.
What will happen to the WordPress Playground codebase when you go on sabbatical. |
@danielbachhuber Modes specifically are a tough one because that’s still an open discussion. However, there’s a few other angles here:
I'd say let's separate them for now, see how that works for both, and pay attention to signs telling us to reconnect them.
@dmsnell will tentatively shepherd WordPress Playground core while I'm away. |
Sounds fine. I think we should create entirely separate repositories for each codebase. Assuming the VS Code Extension gets a bit more traction, it will helpful to have a unique issue tracker. |
… in a dedicated space. See #473. (#475) ## What? Removes the interactive-code-block project from the main WordPress playground repository so it can live in a dedicated space. As outlined in #473, WordPress Playground is re-focusing on [the vision](#472) and separating the framework from the applications. Once `interactive-code-block` is committed into a separate repo, a link will be added to this PR.
@danielbachhuber Thinking about this more, https://github.com/WordPress/playground-tools is just the interactive code block at the moment. I expect some activity there but not much. Moving VS code extension to that same repo will still give it an almost unique issue tracker while reducing the overall fragmentation. If that becomes hard to manage for any reason, it will be easy to move it to its very own repo. It won't experience any core downsides in that repo, too, and will have its own versioning scheme etc. So almost all of the upside while reducing chores over multiple repositories. WDYT? |
I want to keep the momentum here so I'll go ahead and move it to playground-tools for now. I'm not insisting on this particular formula – let's keep talking and make another move tomorrow if needed. I just want to move it out of core and close this issue asap. |
… dedicated space. See #473. (#476) ## What? Removes the VS Code extension from the main WordPress playground repository so it can live in a dedicated space. As outlined in #473, WordPress Playground is re-focusing on [the vision](#472) and separating the framework from the applications. Once the code removed by this PR is committed to a separate repo, a link will be added to this PR.
I think that they should either: 1) all be in the same repository, or 2) all be in separate repositories. I also think we should persist git history when we move them. |
note that it's also possible to create a "grafted commit" in |
Let's do separate repositories, then. Which repo would you like to move wp-now to? |
Is it a good idea to push the changes to Automattics's repo https://github.com/Automattic/wordpress-playground and then rename it to |
Previous changes to wp-now directory can be browsed at https://github.com/WordPress/wordpress-playground/tree/trunk/packages/wp-now Previous changes to bin directory can be browsed at https://github.com/WordPress/wordpress-playground/tree/trunk/bin ## What? Moves `wp-now` from the main WordPress playground repository to a dedicated space. As outlined in WordPress/wordpress-playground#473, WordPress Playground is re-focusing on WordPress/wordpress-playground#472 and separating the framework from the applications.
Previous changes to wp-now directory can be browsed at https://github.com/WordPress/wordpress-playground/tree/trunk/packages/wp-now Previous changes to bin directory can be browsed at https://github.com/WordPress/wordpress-playground/tree/trunk/bin Moves `wp-now` from the main WordPress playground repository to a dedicated space. As outlined in WordPress/wordpress-playground#473, WordPress Playground is re-focusing on WordPress/wordpress-playground#472 and separating the framework from the applications.
As @danielbachhuber pointed out in another conversation, keeping WordPress Playground code under the WordPress organization seems like the most natural choice.
Let's move forward with proposition 1) then. I just moved This concludes moving applications out of the main Playground repo. If you'd like to house these tools in a different repo than |
…space. See #473. (#477) ## What? Removes `wp-now` from the main WordPress playground repository so it can live in a dedicated space. This PR also removes VS Code extension – merge #476 first. As outlined in #473, WordPress Playground is re-focusing on [the vision](#472) and separating the framework from the applications. Once the code removed by this PR is committed to a separate repo, a link will be added to this PR.
As for
I included the link to the previous |
Would it work to just copy the repository and remove whatever we don't need in the new one? |
Yes, this is what I was thinking and I think it would be preferable. |
See WordPress/wordpress-playground#473 for more details
That's a brilliant idea! The history is back @wojtekn @danielbachhuber : https://github.com/WordPress/playground-tools |
Measure twice, cut once 😊 |
I moved all of the @adamziel As remaining cleanup, it would be nice to update https://github.com/WordPress/playground-tools/blob/trunk/CONTRIBUTING.md and make sure publishing works. Otherwise, things seem fine on my end. |
The CONTRIBUTING docs is now updated, let's close this issue and track anything else that might bubble up separately. |
This issue exist to move the applications built with WordPress Playground to dedicated repositories to keep the WordPress Playground project focused on its long-term vision and to help applications built on the Playground to maintain their own faster iteration pace.
Related Pull Requests:
Rationale
The Playground framework and projects built on the Playground have different needs, values, and philosophies. Separating applications from the main framework repository creates an environment that allows both apps and the framework to move at their natural paces, leading to more focused and efficient development.
Applications may prioritize attracting open-source contributions or they may be better-off prioritizing fast iterations by the core team. They may focus on extensibility or they may be better-off prioritizing features. They have varying needs in regard to coding standards, build tools, versioning schemes, CI processes, and project management principles.
Playground, however, have very specific priorities outlined in the vision. It aims to be approachable for new contributors, easy to maintain, and focused on foundational tools. It has specific coding standards, build tools, versioning scheme, CI processes, and project management principles. Every extra package in the Playground repo, no matter how great, makes the codebase a little bit more difficult to approach, adds a little extra time to the weekly maintenance, and makes the project a little bit less focused.
Therefore, it is for the best for WordPress Playground and the applications built using WordPress Playground to grow in a space that’s tailored specifically for their own unique needs.
Next steps
wp-now
is also welcome to move to the above repository, unless the team behind it chooses a different one.The text was updated successfully, but these errors were encountered: