Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground breaks if PHP creates any output during the activatePlugin step #1979

Open
bgrgicak opened this issue Nov 1, 2024 · 0 comments
Open
Assignees
Labels
[Package][@wp-playground] Blueprints [Type] Bug An existing feature does not function as intended

Comments

@bgrgicak
Copy link
Collaborator

bgrgicak commented Nov 1, 2024

The WordPress activate_plugin function will return an error if anything was outputted to the screen during activation.

This will show an error to the user, but it won't break the site, also the plugin will be activated.

If this happens during Playground boot, we will throw an error and the boot process will break.
This happens because we throw all errors during the activatePlugin step.

Recreate issue in Playground using this link.

Potential solution

Because this is only an issue in Blueprints I suggest we catch this unexpected_output error code and return a warning to the logger instead of throwing an error.

This will allow the user to use Playground even if there is an unexpected_output error during boot.

@bgrgicak bgrgicak self-assigned this Nov 1, 2024
@bgrgicak bgrgicak added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] Blueprints labels Nov 1, 2024
@bgrgicak bgrgicak moved this from Inbox to Up next in Playground Board Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] Blueprints [Type] Bug An existing feature does not function as intended
Projects
Status: Up next
Development

No branches or pull requests

1 participant