Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary playground sidebar when there is no Playground #1973

Open
ajotka opened this issue Oct 31, 2024 · 6 comments
Open

Temporary playground sidebar when there is no Playground #1973

ajotka opened this issue Oct 31, 2024 · 6 comments
Labels
[Package][@wp-playground] Website [Type] Bug An existing feature does not function as intended

Comments

@ajotka
Copy link
Contributor

ajotka commented Oct 31, 2024

When there is no temporary playground [1], after entering settings [2] and blueprint gallery [3], and then clicking temporary playground [4], nothing happens in sidebar.
The sidebar for temporary playground should open. (If you click it straight away, without going through the blueprint gallery, it works).

  1. Image
  2. Image
  3. Image
  4. Image
@bph
Copy link
Collaborator

bph commented Oct 31, 2024

The screen is also briefly, very briefly visible when loading a Playground instance from a link.

Here is a short video. Don't blink, though. Following a link from the Gutenberg Examples page.

Screen.Recording.2024-10-31.at.15.05.30.mov

@bgrgicak
Copy link
Collaborator

bgrgicak commented Nov 1, 2024

@ajotka how are you able to recreate this?
The Playground website should always have a temporary site, and if there isn't one it's definetly a bug.

The demo @bph shared looks like a React-related bug where it briefly renders the No Playground screen while Playground is being created.

@bgrgicak bgrgicak moved this from Inbox to Needs Author's Reply in Playground Board Nov 1, 2024
@bgrgicak bgrgicak added [Type] Bug An existing feature does not function as intended [Package][@wp-playground] Website labels Nov 1, 2024
@ajotka
Copy link
Contributor Author

ajotka commented Nov 1, 2024

@bgrgicak looks like it was related to #1908 (comment) and now is fixed :) I tested in local environment, and now it's working.

Should we create a separate issue for reported screen from @bph and close this one?

@adamziel adamziel moved this from Needs Author's Reply to Inbox in Playground Board Nov 1, 2024
@brandonpayton
Copy link
Member

The screen is also briefly, very briefly visible when loading a Playground instance from a link.

Hi @bph, are you referring to this part of the screen recording?
Image

@bgrgicak
Copy link
Collaborator

bgrgicak commented Nov 4, 2024

@brandonpayton I think it was this.

Image

@bgrgicak
Copy link
Collaborator

bgrgicak commented Nov 4, 2024

Should we create a separate issue for reported screen from @bph and close this one?

Sounds good @ajotka! We could also just rename this one if it's something we can address immediately, so that we don't lose the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package][@wp-playground] Website [Type] Bug An existing feature does not function as intended
Projects
Status: Inbox
Development

No branches or pull requests

5 participants