Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video block: Add support for aspect ratio control #66933

Closed
jasmussen opened this issue Nov 12, 2024 · 4 comments · May be fixed by #66946
Closed

Video block: Add support for aspect ratio control #66933

jasmussen opened this issue Nov 12, 2024 · 4 comments · May be fixed by #66946
Assignees
Labels
[Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

The video block does not offer much in the way of dimension tools:

Image

Allowing you to pick an aspect ratio would allow you to more easily combine different poster images of a different size and shape than the video itself, and still allow both to function. This use case came up as part of working on #65776.

To test, this CSS would do the trick:

video {
    aspect-ratio: 1/1;
}
@youknowriad
Copy link
Contributor

This seems like a duplicate of #60911

@up1512001
Copy link
Member

@jasmussen raised PR for this, can you please review 🙇‍♂
#66946

@Mamaduka
Copy link
Member

Closing this as a duplicate of #60911.

@Mamaduka Mamaduka closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
@Mamaduka Mamaduka removed the [Status] In Progress Tracking issues with work in progress label Nov 13, 2024
@jasmussen
Copy link
Contributor Author

Thanks folks for the cleanup! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Video Affects the Video Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants