Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "drag to resize" button for the metabox container is placed after the metaboxes in focus order. #66436

Open
3 of 6 tasks
joedolson opened this issue Oct 24, 2024 · 1 comment · May be fixed by #66735
Open
3 of 6 tasks
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@joedolson
Copy link
Contributor

Description

When using the new drag to resize handle on the metabox container, the position of the control is counter intuitive, because it's located in the DOM after the content. This means that the focus sequence is backwards from expectations, as a user has to tab forward to reach an object above their visible location.

See #64351

Step-by-step reproduction instructions

  1. Enable custom fields in settings > preferences.
  2. Place your tab cursor in the 'value' field.
  3. Tab forward until focus lands on the resize drag button.

Screenshots, screen recording, code snippet

Image

Environment info

  • 6.7 RC nightly on 10/24
  • Gutenberg 19.5

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@joedolson joedolson added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Oct 24, 2024
@stokesman stokesman linked a pull request Nov 5, 2024 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 5, 2024
@stokesman
Copy link
Contributor

stokesman commented Nov 5, 2024

Thanks for opening this. I tried to include a fix for this in #65466 but it complicated things so we left it out. A related PR is #65637 which would be required to fix this while still using the ResizableBox component and it would also enable fixing other instances where that component also causes focus order issues. Alternatively, I’ve opened up #66735 which fixes the issue by not using that component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants