-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to set the homepage in the site editor #63666
Comments
This seems like a fairly straight-forward way to do it. I'd assume, per the separate issue we have for this, that this menu item would also be available in the ⌘K command palette? What happens when you press "Confirm", does the document get marked as "dirty", and you can then actually confirm the change in the multi-entity saving flow? What might that look like? |
Setting a homepage feels a bit like setting a site logo, which does not happen instantly. But perhaps the name can be different from "Confirm"? |
Yup, it's not a strong feeling. I don't mind storing as a pending change.
There is a growing tendency for the button label in such dialogs to echo the action. For instance in the "Move to trash" dialog the primary button is "Trash". Following that convention would give us something like "Set homepage" here, which seems a little long, but might work? It would be good to define this detail more concretely in the systems work cc @mattrwalker. |
While a bit hidden, it seems better than completely absent :) |
Note that there's a draft PR for this here: #65426 |
Since this is a good improvement, since it's in progress already, removing the feedback label. |
Currently to change the homepage you have to exit the site editor and navigate to reading settings which is quite disruptive.
A simple / lightweight method for setting the homepage in the site editor could be a nice enhancement.
Utilise the page actions menu
In both data views and the page Inspector there is an actions menu which could house a shortcut to set the homepage.
Related: #20338
The text was updated successfully, but these errors were encountered: