Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically disable for live streams? #181

Open
WofWca opened this issue Oct 18, 2024 · 0 comments
Open

feat: automatically disable for live streams? #181

WofWca opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@WofWca
Copy link
Owner

WofWca commented Oct 18, 2024

This was raised in this review:

Works amazingly in 95% of cases. The 5% of cases it doesn't work in are YouTube and Twitch streams (it will constantly try to skip ahead if there's dead air but since it's live, the audio just sounds like the stream is skipping a bunch). If you could blacklist specific sites to not run it on(kinda like how uBlock Origin does) the issue with Twitch would be fixed, not sure how YouTube live streams could be handled though. I'd assume YouTube uses the same video player for both streams/videos so differentiating between a stream and video may be impossible for the developer but idk.

EDIT: It seems the developer is aware of people wanting to blacklist sites as there have been suggestions for this feature on the extension's repo; however, it seems that Firefox makes it more complicated to do than Chrome.

The way I see it is some users don't want to be bothered constantly toggling the extension on and off manually, so I thought that perhaps it would make sense to add a on-by-default feature to set playbackRate to 1 and stop skipping if we're near the end of the video (by comparing video.duration and video.currentTime).
It should still be skipping if we're not near the end of a live stream I suppose.

And I suppose some refactoring might be required. Because we probably don't want to do this by actually changing the settings back and forth. Instead we want to override the sounded speed and volume threshold when passing it to a ElementPlaybackController.

Workarounds

@WofWca WofWca added the enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant