Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Easy mode" settings #158

Open
WofWca opened this issue May 28, 2023 · 1 comment · May be fixed by #180
Open

"Easy mode" settings #158

WofWca opened this issue May 28, 2023 · 1 comment · May be fixed by #180

Comments

@WofWca
Copy link
Owner

WofWca commented May 28, 2023

To new and potential users the popup probably looks pretty scary. "Speech loudness"?? "Margin"??? Wat? Can't we just have one slider that is just marked "slower vs faster" ("skip more vs skip less")?

image

I think we can. We can make this slider control all the relevant parameters, including volumeThreshold, silenceSpeed, marginAfter. Just make the value of each of the concrete setting a function (probably linear) of the said single input.

This approach has been sighted in an FL Studio plugin called "Soundgoodizer":

image

Related: #157, #108, #110, #46.

@WofWca
Copy link
Owner Author

WofWca commented Jun 8, 2024

Ok, I have a concrete plan for a start:

  • Introduce "advanced settings" toggle improvement(options): separate some settings into "advanced settings" #86
  • Introduce a new translation string for the "volume threshold" value, something like "how much to skip", "amount to skip", "skip less / skip more". Keep the old string, and use the new string by default, when "advanced settings" are off
  • Hide "margin before" and "margin after" by default. (BTW what should we set their values to when they're hidden? Just set to defaults. makes sense). Perhaps even "silence speed".
  • Hide the "silence speed" when "experimental" is active and "advanced" is off.
  • Hide the "regular speed" input when "I want to control playback rate (sounded speed) through the website's UI" is selected in options (which is the default). Also add an option to still show the input when
  • Consider making the "⚙" open a drop-down, with options "show advanced options" and "settings".
  • Keep the things as is for the users that already have the extension installed.

@WofWca WofWca linked a pull request Nov 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant