Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Emoji option #5

Open
Hammster opened this issue Jan 20, 2020 · 2 comments
Open

Disable Emoji option #5

Hammster opened this issue Jan 20, 2020 · 2 comments
Labels
enhancement New feature or request v2

Comments

@Hammster
Copy link

Is your feature request related to a problem? Please describe.
Most windows setups have difficulties with emojis, this can be dependent on the TTY, PTY or font used. For example it works in the new Windows terminal (preview) and Powershell Core(6.) but not from CMD, VSCode or VisualStudio with Powershell Core(6.).

image

Describe the solution you'd like
A simple option to disable/enable emojis at one place. The developers can decide if they want to toggle it for their environment.

@WoLfulus
Copy link
Owner

Hi @Hammster!

I'm rethinking most of zoya for v2, so there might be a place for these toggles and better handling for field options. For now, I think the best solution for your case is creating a new custom logger with a field pipeline that has no emojis 😞

You can take a look at https://github.com/WoLfulus/zoya/blob/master/examples/custom.ts on how to do that.

@WoLfulus WoLfulus added enhancement New feature or request v2 labels Jan 21, 2020
@Hammster
Copy link
Author

Hammster commented Jan 21, 2020

That's exactly how I resolved it for now, it's just a nice-to-have addition. So, no hurry 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2
Projects
None yet
Development

No branches or pull requests

2 participants