Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side callbacks are hiding errors / failing silently #131

Open
eric-burel opened this issue Sep 27, 2021 · 0 comments
Open

Server-side callbacks are hiding errors / failing silently #131

eric-burel opened this issue Sep 27, 2021 · 0 comments
Labels
bug Something isn't working hacktoberfest

Comments

@eric-burel
Copy link
Collaborator

Describe the bug

Callback behaviour is not predictible enough.

To Reproduce
For instance, I had forgottoen to import crypto in the hashPassword function of the user model.

The user creation callback was failing, but silently :(

Expected behavior

Fail explicitely, except if the callback is specifically marked as failing silently. More broadly, handle server-error correctly => they should return a 500 but should not fail the whole server.

@eric-burel eric-burel added the bug Something isn't working label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant