Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reachable dependency with get-url #1097

Open
curt-weber opened this issue Aug 2, 2024 · 3 comments
Open

fix: Reachable dependency with get-url #1097

curt-weber opened this issue Aug 2, 2024 · 3 comments
Labels
feature A new feature or request p3 Issues that we currently consider unimportant

Comments

@curt-weber
Copy link

curt-weber commented Aug 2, 2024

Description
At Git::reachable when checking the ls-remote it doesn't pass --get-url which can be useful with git config overrides (such as insteadOf).

Steps To Reproduce

  1. Add a rewrite: `git config --global url."[email protected]:ORG/repo.git".insteadOf "[email protected]:ORG/repo.git"
  2. Attempt to pull dependencies: very_good packages get
  3. Notice that it doesn't respect rewrite
  4. Attempt to pull dependencies: flutter pub get
  5. Respects rewrite

Expected Behavior
If --get-url is passed the reachable check will resolve similarly to the actual pull

Additional context

@curt-weber curt-weber added the bug Something isn't working as expected label Aug 2, 2024
@alestiago alestiago added waiting for response Waiting for follow up and removed waiting for response Waiting for follow up labels Aug 13, 2024
@alestiago
Copy link
Contributor

Hi @curt-weber thanks for this issue!

I haven't tried reproducing it, but it seems that it's a valid request. I've added a reference to the insteadOf documentation to your original issue.

If you're interesting in solving this issue let us know and I can assign this to you! If you have any questions the team might be able to help.

For now this issue requires to be triaged, you might be able to track its status changes within the Full Board.

@curt-weber
Copy link
Author

We use this insteadOf functionality since we have multiple dependencies with different SSH keys and we can configure git to use a specific user for different repositories. I could certainly create a PR adding --get-url, but I imagine it would also need tests etc. and I doubt I would be able to get to it in the near-term if that was the case.

@alestiago
Copy link
Contributor

It would require tests, but any contribution is appreciated. Maybe the team is able to pick writing those tests up or another contributor may be able to finish it off; so making a starting draft PR is welcomed!

There's a CONTRIBUTING document that might help getting started.

@tomarra tomarra moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Aug 27, 2024
@tomarra tomarra added p3 Issues that we currently consider unimportant feature A new feature or request and removed bug Something isn't working as expected labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request p3 Issues that we currently consider unimportant
Projects
Status: Backlog
Development

No branches or pull requests

3 participants