Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reporting of malformed licenses #1016

Open
dominicmh opened this issue Apr 10, 2024 · 2 comments
Open

fix: Reporting of malformed licenses #1016

dominicmh opened this issue Apr 10, 2024 · 2 comments
Labels
bug Something isn't working as expected has reproductive steps This issue contains detailed steps to reproduce the issue p1 High-priority issues at the top of the work list

Comments

@dominicmh
Copy link

dominicmh commented Apr 10, 2024

Description
very_good packages check licenses fails to report pubs with unknown licenses (e.g. rxdart):

$ very_good packages check licenses
✓ Retrieved 0 licenses from 1 package. (0.7s)

Steps To Reproduce

  1. Clone example repo (includes rxdart dependency in pubspec.lock)
  2. Execute dart pub global activate very_good_cli; very_good packages check licenses

Expected Behavior
✓ Retrieved 1 license from 1 package of type: unknown (1).

Actual Behavior
✓ Retrieved 0 licenses from 1 package.

@dominicmh dominicmh added the bug Something isn't working as expected label Apr 10, 2024
@alestiago
Copy link
Contributor

alestiago commented May 16, 2024

Hi @dominicmh thanks for opening an issue! And sorry for the late reply, I haven't been able to catch-up recently.

I've been able to reproduce this issue by using the following pubspec.yaml.

puspec.yaml
name: example
description: An example project.
version: 1.0.0+1
publish_to: none

environment:
  sdk: "^3.3.0"

dependencies:
  rxdart: ^0.27.7

@dominicmh are you interested in contributing with a fix? If so, let me know and I can assign you to this item and assist you on landing it 🙌

@alestiago alestiago added the has reproductive steps This issue contains detailed steps to reproduce the issue label May 16, 2024
@alestiago alestiago added the waiting for response Waiting for follow up label May 16, 2024
@dominicmh
Copy link
Author

dominicmh commented May 16, 2024

Hi @alestiago – I can't really promise any delivery date, could be weeks or even months. But generally I'm open to fix this.

@tomarra tomarra removed the waiting for response Waiting for follow up label May 17, 2024
@tomarra tomarra moved this from Needs Triage to Todo in VGV Open Source 🦄 🧙🌟 May 17, 2024
@tomarra tomarra added the p1 High-priority issues at the top of the work list label May 17, 2024
@tomarra tomarra moved this from Todo to Backlog in VGV Open Source 🦄 🧙🌟 May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected has reproductive steps This issue contains detailed steps to reproduce the issue p1 High-priority issues at the top of the work list
Projects
Status: Backlog
Development

No branches or pull requests

3 participants