Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: remove deprecated defaultProps #1218

Open
bobular opened this issue Oct 3, 2024 · 1 comment · May be fixed by #1226
Open

Tech debt: remove deprecated defaultProps #1218

bobular opened this issue Oct 3, 2024 · 1 comment · May be fixed by #1226
Assignees
@asizemore
Labels
technical debt

Comments

@bobular
Copy link
Member

bobular commented Oct 3, 2024

Saw this in browser console

CheckboxTree: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

A bit of grepping suggests some others may need doing too

packages/libs/wdk-client/src/Views/Answer/AnswerTable.jsx
packages/libs/wdk-client/src/Views/Records/RecordNavigation/RecordNavigationSection.jsx
packages/libs/wdk-client/src/Views/Records/RecordActionLink.jsx
packages/libs/wdk-client/src/Core/Root.tsx
packages/libs/wdk-client/src/Components/Display/TabbableContainer.tsx
packages/libs/wdk-client/src/Components/InputControls/NativeCheckboxList.tsx
packages/libs/wdk-client/src/Components/Overlays/Popup.tsx
packages/libs/wdk-client/src/Components/Shared/Spinnable.tsx
packages/libs/wdk-client/src/Components/SearchBox/RealTimeSearchBox.tsx
packages/libs/wdk-client/src/Components/AttributeFilter/FieldFilter.jsx
packages/libs/wdk-client/src/Components/AttributeFilter/MembershipField.jsx
packages/libs/wdk-client/src/Components/AttributeFilter/ServerSideAttributeFilter.jsx
packages/libs/wdk-client/src/Components/AttributeFilter/Histogram.jsx
packages/libs/coreui/src/components/inputs/checkboxes/CheckboxTree/CheckboxTree.tsx
packages/libs/coreui/src/components/inputs/SelectTree/SelectTree.tsx
packages/libs/coreui/src/assets/icons/CaretDown.tsx
packages/libs/coreui/src/assets/icons/CaretUp.tsx
packages/libs/coreui/src/assets/icons/DoubleArrow.tsx
packages/libs/coreui/src/assets/icons/Cancel.tsx
packages/libs/coreui/src/assets/icons/Arrow.tsx
packages/libs/web-common/src/components/records/Sequence.tsx
packages/libs/web-common/src/util/customElements.jsx
@bobular
Copy link
Member Author

bobular commented Oct 3, 2024

Also while we're at it!

Warning: findDOMNode is deprecated and will be removed in the next major release. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

@asizemore asizemore self-assigned this Oct 7, 2024
@asizemore asizemore linked a pull request Oct 9, 2024 that will close this issue
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asizemore asizemore

Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exchange defaultProps for default parameters in function components VEuPathDB/web-monorepo
2 participants
@bobular @asizemore