JOSS manuscript comments #54
Replies: 3 comments 1 reply
-
Pushed suggested revisions to #52 (9df32d7) Remaining To-Do
|
Beta Was this translation helpful? Give feedback.
-
As a reader not entirely privy to epidemiological modeling: Line 87 in ce4b880 SIR (mentioned in other lines as well), SIS, and SEIR are mentioned without any explanation for what the acronyms stand for. For an audience that is not familiar with these models, it might be helpful to write out what they stand for. Line 58 in ce4b880 The explanation prior to this line about how other packages have limitations reasonably demonstrates why there is a need for Episimlab. However, I feel that this line (line 58) does not accurately reflect that your SDK will make up for the limitations present in other packages. I would reword to make this more clear to a general audience. Overall, I could reasonably follow along for a substantial amount of it, and I believe addressing the comments above will help for a general audience. |
Beta Was this translation helpful? Give feedback.
-
@kellypierce I'm looking around on the consortium publications page for the citations for |
Beta Was this translation helpful? Give feedback.
-
episimlab/paper.md
Line 26 in ce4b880
Change "are therefore well suited to" to "can be applied to" (since the examples listed require additional infrastructure on top of the compartmental model)
episimlab/paper.md
Line 29 in ce4b880
Consider changing "viral" to "pathogen" genomics.
episimlab/paper.md
Line 30 in ce4b880
Don't end sentence with conjunction.
episimlab/paper.md
Line 39 in ce4b880
Are there any constraints on the topology of the graph? It can be cyclic, right (e.g. an SIRS model)
episimlab/paper.md
Line 40 in ce4b880
It might be helpful to provide a brief example here, along the lines of "... varying dimensions such as age-depended recovery rates, location-dependent contact patterns, and other demographically stratified risk factors." (but shorten if that seems too long)
episimlab/paper.md
Line 41 in ce4b880
Change to "Simulate interventions, including dynamic interventions such as ...."
episimlab/paper.md
Line 44 in ce4b880
"approachable" and "easily" are somewhat subjective; maybe replace approachable with "extensible" and omit easily
episimlab/paper.md
Line 45 in ce4b880
You could reframe as "different or more complex"
episimlab/paper.md
Line 59 in ce4b880
What do you mean by "Markov state matrix" here?
episimlab/paper.md
Line 63 in ce4b880
Not sure about this citation (I'll find one from the epi literature to replace). Recommend replacing "Markovian" with "deterministic or stochastic". Also specify that transitions are drawn from a Poisson distribution. (I think the term "Markovian" is correct here, but I don't typically hear these types of models described as such. And I suppose it's technically possible to have a non-Markovian stochastic implementation...)
episimlab/paper.md
Line 70 in ce4b880
Replace "forecasting" with "projecting"
episimlab/paper.md
Line 103 in ce4b880
Need to add citations for the partition_v1 model and for the vaccine model. (I'll find and add)
Beta Was this translation helpful? Give feedback.
All reactions