Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lily/Skins - Add option to not pause blocks while waiting for a skin to load #1560

Open
LilyMakesThings opened this issue Jun 21, 2024 · 3 comments

Comments

@LilyMakesThings
Copy link
Contributor

This is something I'm going to work on if I have the time.

Right now each loading block in Skins will pause until it's finished loading the skin. That's fine in circumstances where someone new to the extension might be confused why their blocks don't work, but in advanced cases where loading several skins in (sometimes hundreds) is necessary, the waiting can add up

As I understand it, there's no performance reason why it would need to wait.

My current plan is to add a block that'll enable/disable the "waiting", but I'm not settled on it yet.

@veggiecan0419
Copy link
Contributor

Or an and wait dropdown?

@SharkPool-SP
Copy link
Collaborator

SharkPool-SP commented Jun 24, 2024

This is something I'm going to work on if I have the time.

Right now each loading block in Skins will pause until it's finished loading the skin. That's fine in circumstances where someone new to the extension might be confused why their blocks don't work, but in advanced cases where loading several skins in (sometimes hundreds) is necessary, the waiting can add up

As I understand it, there's no performance reason why it would need to wait.

My current plan is to add a block that'll enable/disable the "waiting", but I'm not settled on it yet.

can I do it

@DNin01
Copy link
Collaborator

DNin01 commented Jun 28, 2024

Skins could be loaded concurrently (e.g. in a web worker) to avoid lag (if that's possible), but creators could also use loading screens so users don't notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants