Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backticks in linux example makefile #267

Open
son0p opened this issue Oct 2, 2015 · 4 comments
Open

Backticks in linux example makefile #267

son0p opened this issue Oct 2, 2015 · 4 comments

Comments

@son0p
Copy link
Contributor

son0p commented Oct 2, 2015

To compile for UNIX_JACK I had to put backticks to part of line 52

https://github.com/TonicAudio/Tonic/blob/master/examples/Standalone/Linux/Makefile#L53

not working :

ifeq ($(AUDIO_API),UNIX_JACK)
RTAUDIO_LIBS = pkg-config --cflags --libs jack -lpthread

working

ifeq ($(AUDIO_API),UNIX_JACK)
RTAUDIO_LIBS = `pkg-config --cflags --libs jack` -lpthread

thanks to @falkTX

@falkTX
Copy link

falkTX commented Oct 2, 2015

you forgot that github uses those as special characters. the working version is this:

`pkg-config --cflags --libs jack` -lpthread

@son0p
Copy link
Contributor Author

son0p commented Oct 2, 2015

corrected, thanks

@morganpackard
Copy link
Member

Thanks!
I don't know a thing about makefiles. Can anyone else confirm that this is
a change that should be added to the main repository? If so, I'll accept a
PR for it.

On Fri, Oct 2, 2015 at 1:31 PM, federico lopez [email protected]
wrote:

corrected, thanks


Reply to this email directly or view it on GitHub
#267 (comment).

Morgan Packard
cell: (720) 891-0122
twitter: @morganpackard

@falkTX
Copy link

falkTX commented Oct 2, 2015

yes, that change is fine.
without it you're adding "pkg-config..." directly as gcc arguments, which of course doesn't work.

morganpackard added a commit that referenced this issue Oct 16, 2015
Add backticks for build to UNIX_JACK. #267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants