Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RampedValue::isFinished time-accurate for flat ramps? #233

Open
morganpackard opened this issue Dec 9, 2013 · 1 comment
Open

Make RampedValue::isFinished time-accurate for flat ramps? #233

morganpackard opened this issue Dec 9, 2013 · 1 comment

Comments

@morganpackard
Copy link
Member

Consider the following

RampedValue().target(0).length(1000).isFinished()

This will evaluate to "true" even though the length was set to 1000. I've been working on ControlRampedValue, and finding that I want to use it as a timer, but the timer capabilities break when the value doesn't change (i.e. when the ramp goes from 0 to 0). I propose making isFinished time-based, rather than value-based.

@ndonald2
Copy link
Member

ndonald2 commented Dec 9, 2013

That makes sense to me. Just FYI, you could also feasibly use ControlDelay or ControlPulse as a timer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants