Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make DidResolutionResult.DidDocument not nullable #93

Open
mistermoe opened this issue Jun 25, 2024 · 0 comments
Open

make DidResolutionResult.DidDocument not nullable #93

mistermoe opened this issue Jun 25, 2024 · 0 comments

Comments

@mistermoe
Copy link
Member

Concretely, DidResolutionResult.didDocument should no longer be nullable, and instead of an error being buried in didResolutionMetadata per the did core spec, we need to throw a DidResolutionException that itself has a didResolutionMetadata member.

This way all errors thrown by didResolver.resolve can be handled in a single code path vs try/catching and checking if resolutionResult.hasError() and didDocument being nullable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant