Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo is on all Ships 0 #5

Open
Lucas-Gruber opened this issue Aug 17, 2024 · 3 comments
Open

Cargo is on all Ships 0 #5

Lucas-Gruber opened this issue Aug 17, 2024 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Lucas-Gruber
Copy link

Hello,
if you look at the Caterpillar data, for example, the cargo value is 0, and I think that applies to all ships.

@octfx
Copy link
Member

octfx commented Aug 31, 2024

Yes that is (sadly) correct, cargo capacity and thrust data is currently broken in the json data.
It works on the Wiki API though, as there we calculate the attributes directly from the hardpoints:
Example for SCU

I did not have the time yet to port this over to scunpacked :/

@octfx octfx added bug Something isn't working enhancement New feature or request labels Aug 31, 2024
@octfx
Copy link
Member

octfx commented Aug 31, 2024

I've ported the logic over in 83e8331
Would you mind confirming if this is correct?

@Lucas-Gruber
Copy link
Author

I don't think its correct. For example if you go to the Constellation Taurus it has Cargo of 6 SCU instead of 174.

Sorry for the really late answer but i didn't had any time because of my job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants