AddSystemFonts overloads

[LeaFrock]

I notice that FontCollectionExtensions provides AddSystemFonts method.

Is it possible to add a overload method like below? This method can filter the fonts not wanted.

        public static FontCollection AddSystemFonts(this FontCollection collection, Predicate<FontMetrics> predicate)
        {
            foreach (FontMetrics? metric in (IReadOnlyFontMetricsCollection)SystemFonts.Collection)
            {
                if(predicate(metric))
                {
                    ((IFontMetricsCollection)collection).AddMetrics(metric);
                }
            }

            return collection;
        }

[tocsoft]

@LeaFrock can you provide use case(s) why this is needed? How the current API is causing issues etc. it'll help us priorities API changes etc.

[JimBobSquarePants]

@tocsoft Current table support issues aside this looks like a pretty useful extension that would add a negligible burden in additional maintenance . What do you think?

[LeaFrock]

Or just change the current method to a compatible one like below,

        public static FontCollection AddSystemFonts(this FontCollection collection, Predicate<FontMetrics>? predicate = default)
        {
            if (predicate is null)
            {
                foreach (FontMetrics? metric in (IReadOnlyFontMetricsCollection)SystemFonts.Collection)
                {
                    ((IFontMetricsCollection)collection).AddMetrics(metric);
                }
            }
            else
            {
                foreach (FontMetrics? metric in (IReadOnlyFontMetricsCollection)SystemFonts.Collection)
                {
                    if (predicate(metric))
                    {
                        ((IFontMetricsCollection)collection).AddMetrics(metric);
                    }
                }
            }
            return collection;
        }

[tocsoft]

@tocsoft Current table support issues aside this looks like a pretty useful extension that would add a negligible burden in additional maintenance . What do you think?

Yeah agreed, I'm personally not huge fan of doing anything that gives the appearance of encouraging the use of system fonts at all, as its just a never ending source of issues (that just filtering is a workaround for) that don't exist if you ship our own fonts with your code.

However I am not opposed enough to try and block this API proposal.

The follow up question however is how breaking a change do we want... it will cause less headaches if we just add a new overload.

[JimBobSquarePants]

Since we try to avoid default values in methods a new overload seems sound. @LeaFrock Fancy raising a PR?

[LeaFrock]

Fancy raising a PR?

With pleasure.