Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add message to set the trim values #60

Open
PBechon opened this issue Jun 26, 2021 · 2 comments
Open

[Feature]: Add message to set the trim values #60

PBechon opened this issue Jun 26, 2021 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@PBechon
Copy link
Collaborator

PBechon commented Jun 26, 2021

The Flight ControlState API allow setting the values for the trim and there is currently no way to set them from the SimpitAPI.

One solution would be to reuse the Rotation message and use the unused bits from the bitmask to indicate that the values in the message should be the new trim value.

@PBechon PBechon added the enhancement New feature or request label Jun 26, 2021
@PBechon PBechon added the help wanted Extra attention is needed label May 18, 2022
@PBechon
Copy link
Collaborator Author

PBechon commented May 18, 2022

The trim values does not seem to work with an autopilot such as the one used by Simpit. Setting the trim values using the FlightCtrlState API does not seem to do anything. I tried to add a new channel that control the trim values (with the same code as the one controlling the rotation, only updating the trim values of the FlightCtrlState).

kOS seems to have the same issue. See here for instance.

Not sure how to proceed from here, except excluding this from the feature we want to support.

@PBechon
Copy link
Collaborator Author

PBechon commented May 19, 2022

For those that want to try, see the diff file of what I tried.

Following a discussion on Discord, adding trim can be done in the controller without using KSP builin trim. It seems also that KSP built-in trim are not used when setting rotation command the way we use them, meaning that the controller command will in any way ignore KSP trim. So I suggest not to implement a message to set KSP trim values with Simpit and instead favor a trim setting Arduino side, by each user.

@PBechon PBechon added wontfix This will not be worked on and removed help wanted Extra attention is needed labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant