Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brakeman integration #370

Open
andyw8 opened this issue May 4, 2024 · 1 comment
Open

Brakeman integration #370

andyw8 opened this issue May 4, 2024 · 1 comment

Comments

@andyw8
Copy link
Contributor

andyw8 commented May 4, 2024

Rails 8 will add Brakeman: https://www.shakacode.com/blog/rails-8-adds-brakeman-by-default/

We could surface Brakeman's warnings within the editor.

Brakeman support should probably exist in a separate addon, but for initial investigation/prototyping it could be part of the ruby-lsp-rails addon.

The Guard plugin for Brakeman may be a useful reference understanding the APIs available: https://github.com/guard/guard-brakeman

@andyw8 andyw8 added the railsconf-hackday Issues intented for working on during RailsConf 2024 Hack Day label May 4, 2024
@vinistock
Copy link
Member

I think it's worth prototyping. However, I do have a performance concern with making this a default. We already pay a high price re-parsing documents a second time because RuboCop uses a different AST than the Prism one.

Brakeman would introduce a third parsing pass on every document, which has significant potential for slow downs.

@andyw8 andyw8 added rubyconf-hackday and removed railsconf-hackday Issues intented for working on during RailsConf 2024 Hack Day labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants