Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Error when dist generation doesn't recognize a value. #352

Open
tylerrowsell opened this issue Oct 1, 2024 · 1 comment
Open

Throw Error when dist generation doesn't recognize a value. #352

tylerrowsell opened this issue Oct 1, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@tylerrowsell
Copy link
Member

tylerrowsell commented Oct 1, 2024

          missing underscores here.

Originally posted by @tylerrowsell in #349 (comment)

This should have been caught by dist generation not being able to find the attribute. We should throw an error when reading these files into the DB if an attribute can't be found.

A little more details...

When parsing the data files to load into the database, if an attribute or value is missing when referenced by a category or attribute, an error should be thrown so the user knows it failed.

@tylerrowsell tylerrowsell added the good first issue Good for newcomers label Oct 1, 2024
@elsom25
Copy link
Collaborator

elsom25 commented Oct 1, 2024

When parsing the data files to load into the database, if an attribute or value is missing when referenced by a category or attribute, an error should be thrown so the user knows it failed.

The seeding itself doesnt do checking for performance reasons. But the integration tests check this. We can maybe instrument our dev commands to invoke both (basically a manual seed does it; the raw seed continues to go fast)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants