Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexFilter cancel | close using esc key seems like doesn't fire the cancelAction or onClearAll callback #12754

Open
maruffahmed opened this issue Oct 7, 2024 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@maruffahmed
Copy link

Summary

I found the the IndexFilter component is not behaving as I expected.

Expected behavior

I expect to fire the same callback I'm using for cancelAction when pressing esc from the keyboard to close the index table filter.

Actual behavior

Wrap animated gifs/videos in a details tag:
https://github.com/user-attachments/assets/b30d3770-be8b-4e6c-afba-7d133512c381

Steps to reproduce

System:
OS: macOS 15.0.1
CPU: (8) arm64 Apple M1
Memory: 86.70 MB / 8.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.15.0 - ~/.nvm/versions/node/v20.15.0/bin/node
Yarn: 1.22.22 - /opt/homebrew/bin/yarn
npm: 10.7.0 - ~/.nvm/versions/node/v20.15.0/bin/npm
pnpm: 8.15.8 - /opt/homebrew/opt/pnpm@8/bin/pnpm
Browsers:
Brave Browser: 129.1.70.123
Chrome: 129.0.6668.90
Safari: 18.0.1

Are you using React components?

Yes

Polaris version number

13.1.2

Browser

Chrome: 129.0.6668.90

Device

OS: macOS 15.0.1 CPU: (8) arm64 Apple M1 Memory: 86.70 MB / 8.00 GB Shell: 5.9 - /bin/zsh

@maruffahmed maruffahmed added Bug Something is broken and not working as intended in the system. untriaged labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant